Skip to content

perf(@angular/ssr): optimized request handling performance #29909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 1 commit into from
Mar 21, 2025
Merged

perf(@angular/ssr): optimized request handling performance #29909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/angular/ssr/src/utils/ng.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,16 @@ export async function renderAngular(
await applicationRef.whenStable();

return {
content: async () => {
try {
return renderInternal(platformRef, applicationRef);
} finally {
await asyncDestroyPlatform(platformRef);
}
},
content: () =>
new Promise<string>((resolve, reject) => {
// Defer rendering to the next event loop iteration to avoid blocking, as most operations in `renderInternal` are synchronous.
setTimeout(() => {
renderInternal(platformRef, applicationRef)
.then(resolve)
.catch(reject)
.finally(() => void asyncDestroyPlatform(platformRef));
}, 0);
}),
};
} catch (error) {
await asyncDestroyPlatform(platformRef);
Expand Down