Skip to content

refactor(@angular/build): remove Component HMR has been enabled warning #29957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

refactor(@angular/build): remove Component HMR has been enabled warning #29957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 0 additions & 83 deletions packages/angular/build/src/builders/dev-server/tests/options/hmr_spec.ts
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions packages/angular/build/src/builders/dev-server/vite-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,6 @@ export async function* serveWithVite(
// This will also replace file-based/inline styles as code if external runtime styles are not enabled.
browserOptions.templateUpdates =
serverOptions.liveReload && serverOptions.hmr && useComponentTemplateHmr;
if (browserOptions.templateUpdates) {
context.logger.warn(
'Component HMR has been enabled.\n' +
'If you encounter application reload issues, you can manually reload the page to bypass HMR and/or disable this feature with the' +
' `--no-hmr` command line option.\n' +
'Please consider reporting any issues you encounter here: https://github.com/angular/angular-cli/issues\n',
);
}

browserOptions.incrementalResults = true;

// Setup the prebundling transformer that will be shared across Vite prebundling requests
Expand Down