fix(@schematics/angular): infer app component name and path in server schematic #30028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
the
action: review
crisbeto
commented
Apr 4, 2025
...s/schematics/angular/server/files/application-builder/standalone-src/main.server.ts.template
Show resolved
Hide resolved
crisbeto
force-pushed
the
server-schematic-name
branch
from
597af7f to
2397b22
Compare
Member
Author
|
I've pushed some more code to properly handle NgModule-based apps as well. It's ready for another review. |
crisbeto
force-pushed
the
server-schematic-name
branch
from
2397b22 to
75f1500
Compare
… schematic Currently the `server` schematic assumes that the app component is called `App` and it's places in `./app/app`. This will fail if the user renamed it or moved it to a different file. These changes add a utility function to resolve the component name and path from the source the source code, and they use the new function to produce a more accurate result.
crisbeto
force-pushed
the
server-schematic-name
branch
from
75f1500 to
d9af817
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
serverschematic assumes that the app component is calledAppand it's places in./app/app. This will fail if the user renamed it or moved it to a different file.These changes add a utility function to resolve the component name and path from the source the source code, and they use the new function to produce a more accurate result.