Skip to content

fix(@angular/build): Must respect externalDependencies #30061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(@angular/build): Must respect externalDependencies #30061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/angular/build/src/builders/application/execute-build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ export async function executeBuild(
// This means all paths within the @foo/bar package are also marked as external.
const exclusionsPrefixes = externalConfiguration.map((exclusion) => exclusion + '/');
const exclusions = new Set(externalConfiguration);
const explicitExternal = new Set<string>();

const isExplicitExternal = (dep: string): boolean => {
if (exclusions.has(dep)) {
Expand All @@ -189,23 +188,19 @@ export async function executeBuild(

const implicitBrowser: string[] = [];
for (const dep of browser) {
if (isExplicitExternal(dep)) {
explicitExternal.add(dep);
} else {
if (!isExplicitExternal(dep)) {
implicitBrowser.push(dep);
}
}

const implicitServer: string[] = [];
for (const dep of server) {
if (isExplicitExternal(dep)) {
explicitExternal.add(dep);
} else {
if (!isExplicitExternal(dep)) {
implicitServer.push(dep);
}
}

executionResult.setExternalMetadata(implicitBrowser, implicitServer, [...explicitExternal]);
executionResult.setExternalMetadata(implicitBrowser, implicitServer, [...exclusions]);
}

const { metafile, initialFiles, outputFiles } = bundlingResult;
Expand Down