refactor: minor code changes in karma AngularAssetsMiddleware

[alan-agius4]

Early exits and reduce optional chaining.

[jkrems]

This does now have the potential to call next multiple times in case of errors. But that might be okay..?

(The code invoked by next() may throw which then could get caught by this function and trigger a 2nd call to next().)

[alan-agius4]

This does now have the potential to call next multiple times in case of errors. But that might be okay..?

(The code invoked by next() may throw which then could get caught by this function and trigger a 2nd call to next().)

Yes, that should be fine though, what was the intent of the try/catch was it to catch error from this.serveFile or handle invalid new URL?

[jkrems]

Yes, that should be fine though, what was the intent of the try/catch was it to catch error from this.serveFile or handle invalid new URL?

That's a good point! Since this entirely synchronous, we could likely depend on the framework to catch errors and remove the try/catch.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}