fix(@angular/build): perform testing module cleanup when using Vitest #30188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
state: blocked
target: major
alan-agius4
added a commit
to alan-agius4/angular
that referenced
this pull request
Apr 28, 2025
Expose `getCleanupHook` as a private export to address integration issues with Vitest. In Vitest, `globalThis.beforeEach` and `globalThis.afterEach` are not available by default. Additionally, these hooks are patched during module evaluation, complicating seamless integration with Vitest. See: angular/angular-cli#30188
alan-agius4
force-pushed
the
vitest-cleanup
branch
from
40ce720 to
7b6abea
Compare
alan-agius4
added
the
action: review
mmalerba
pushed a commit
to angular/angular
that referenced
this pull request
Apr 29, 2025
Expose `getCleanupHook` as a private export to address integration issues with Vitest. In Vitest, `globalThis.beforeEach` and `globalThis.afterEach` are not available by default. Additionally, these hooks are patched during module evaluation, complicating seamless integration with Vitest. See: angular/angular-cli#30188 PR Close #61017
clydin
added
target: rc
Ensure proper cleanup of the Angular testing module when running tests with Vitest. Closes: angular#30186
alan-agius4
force-pushed
the
vitest-cleanup
branch
from
7b6abea to
3d54741
Compare
clydin
approved these changes
May 2, 2025
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure proper cleanup of the Angular testing module when running tests with Vitest.
Closes: #30186
Blocked on angular/angular#61017 being released on NPM