Skip to content

fix(@schematics/angular): skip spec project reference for minimal ng new #30190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

fix(@schematics/angular): skip spec project reference for minimal ng new #30190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/schematics/angular/application/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export default function (options: ApplicationOptions): Rule {
return chain([
addAppToWorkspaceFile(options, appDir, folderName),
addTsProjectReference('./' + join(normalize(appDir), 'tsconfig.app.json')),
options.skipTests
options.skipTests || options.minimal
? noop()
: addTsProjectReference('./' + join(normalize(appDir), 'tsconfig.spec.json')),
options.standalone
Expand Down
16 changes: 16 additions & 0 deletions packages/schematics/angular/application/index_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,22 @@ describe('Application Schematic', () => {
);
});

it('should not add spec project reference in the root tsconfig.json with "minimal" enabled', async () => {
const tree = await schematicRunner.runSchematic(
'application',
{ ...defaultOptions, minimal: true },
workspaceTree,
);

const { references } = readJsonFile(tree, '/tsconfig.json');
expect(references).toContain(
jasmine.objectContaining({ path: './projects/foo/tsconfig.app.json' }),
);
expect(references).not.toContain(
jasmine.objectContaining({ path: './projects/foo/tsconfig.spec.json' }),
);
});

it('should install npm dependencies when `skipInstall` is false', async () => {
await schematicRunner.runSchematic(
'application',
Expand Down
Loading