Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 28, 2025

With the index option now defaulting to <project_source_root>/index.html for the application build system, the explicit value present in new applications is no longer required. This removal further reduces the size of the angular.json file for new projects.

@clydin clydin added the target: major This PR is targeted for the next major release label Apr 28, 2025
@clydin clydin force-pushed the ng-new/default-index branch 3 times, most recently from ad5d672 to 4968791 Compare April 29, 2025 00:39
@clydin clydin added this to the v20 Candidates milestone Apr 30, 2025
@clydin clydin marked this pull request as ready for review April 30, 2025 15:00
@clydin clydin added target: rc This PR is targeted for the next release-candidate and removed target: major This PR is targeted for the next major release labels Apr 30, 2025
clydin added 2 commits April 30, 2025 19:52
…cations

With the index option now defaulting to `<project_source_root>/index.html`
for the `application` build system, the explicit value present in new
applications is no longer required. This removal further reduces the size
of the `angular.json` file for new projects.
The `@angular/pwa` add schematic now attempts to discover a default index
option value if a configuration usage path within the build target is
possible. The default value as per the `application` build system is
`<project_source_root>/index.html`.
@clydin clydin force-pushed the ng-new/default-index branch from 4968791 to d655307 Compare April 30, 2025 23:52
@clydin clydin requested a review from alan-agius4 May 1, 2025 14:38
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 1, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 2, 2025
@clydin clydin merged commit 8129483 into angular:main May 2, 2025
52 of 56 checks passed
@clydin
Copy link
Member Author

clydin commented May 2, 2025

The changes were merged into the following branches: main, 20.0.x

@clydin clydin deleted the ng-new/default-index branch May 2, 2025 11:04
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/pwa area: @schematics/angular target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants