Skip to content

Conversation

jkrems
Copy link
Contributor

@jkrems jkrems commented May 7, 2025

Since this class isn't a "real" Set, we can't promise that our iterators are true SetIterator<T>s.

Follow-up to #30226.

@jkrems jkrems requested a review from clydin May 7, 2025 14:59
@jkrems jkrems added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels May 7, 2025
@jkrems jkrems force-pushed the jk-no-set-iterator branch from a1be2ad to 4c41f22 Compare May 7, 2025 15:05
Since this class isn't a "real" `Set`, we can't promise that our
iterators are true `SetIterator<T>`s.
@jkrems jkrems force-pushed the jk-no-set-iterator branch from 4c41f22 to 8f917a1 Compare May 7, 2025 15:57
@jkrems jkrems added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 7, 2025
@clydin clydin merged commit 16ae68a into angular:main May 7, 2025
31 checks passed
@clydin
Copy link
Member

clydin commented May 7, 2025

The changes were merged into the following branches: main, 20.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 7, 2025
@jkrems jkrems deleted the jk-no-set-iterator branch August 20, 2025 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular-devkit/core target: rc This PR is targeted for the next release-candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants