fix(@angular/build): allow TestBed provider configuration with vitest unit-testing #30276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybrist
approved these changes
May 9, 2025
Contributor
hybrist
left a comment
hybrist
left a comment
There was a problem hiding this comment.
That's a really neat solution for this!
alan-agius4
added
the
action: review
alan-agius4
requested changes
May 9, 2025
| `import { beforeEach, afterEach } from 'vitest';`, | ||
| '', | ||
| normalizedOptions.providersFile | ||
| ? `import providers from './${path.relative(projectSourceRoot, normalizedOptions.providersFile)}'` |
Collaborator
There was a problem hiding this comment.
A couple of notes:
path.relativewill return backslashes on Windows, which will break the import paths.- The file extension (.ts) is retained. Can this cause issues? (I guess not as this is not typechecked).
- Instead of using
projectSourceRoot, it probably makes more sense to useworkspaceRoot, since paths inangular.jsonare all relative to the workspace root.
We handle a similar case here for reference:
Member
Author
There was a problem hiding this comment.
Added the extra cleanup logic from the linked code.
alan-agius4
added
action: cleanup
… unit-testing
The experimental `unit-test` builder with the `vitest` runner configured
can now specify an Angular providers file via the `providersFile` option.
This allows the TestBed initialization to use the providers defined in
this file for all executed tests. The contents of the providers file should
include a default export with an array of one or more Angular providers.
As an example:
```
import { provideZonelessChangeDetection } from '@angular/core';
export default [
provideZonelessChangeDetection(),
];
```
clydin
force-pushed
the
unit-test/allow-providers-file
branch
from
ac0c952 to
a368d62
Compare
clydin
removed
the
action: cleanup
alan-agius4
approved these changes
May 12, 2025
Member
Author
|
The changes were merged into the following branches: main, 20.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental
unit-testbuilder with thevitestrunner configured can now specify an Angular providers file via theprovidersFileoption. This allows the TestBed initialization to use the providers defined in this file for all executed tests. The contents of the providers file should include a default export with an array of one or more Angular providers. As an example: