fix(@schematics/angular): remove karma config devkit package usages during application migration #30415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
update/karma-config-application
branch
from
a2856a2 to
3c2461e
Compare
jkrems
approved these changes
May 29, 2025
packages/schematics/angular/migrations/use-application-builder/migration.ts
Outdated
Show resolved
Hide resolved
…uring application migration When performing an `ng update` to Angular v20, the application migration will detect the usage of the `karma` builder's `karmaConfig` option and attempt to remove usages of the no longer needed `@angular-devkit/build-angular` karma framework and plugin usage. While the karma framework usage will be specifically ignored when using the `@angular/build:karma` builder, the plugin usage leverages a direct `require` within the configuration file. Regardless of the ability of the builder to ignore, neither usage is needed with `@angular/build:karma` and removing the code aligns with what would be generated by `ng generate config karma`.
clydin
force-pushed
the
update/karma-config-application
branch
from
3c2461e to
4075d2b
Compare
|
The changes were merged into the following branches: main, 20.0.x |
kevinslawinski
added a commit
to kevinslawinski/about
that referenced
this pull request
Jun 1, 2025
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing an
ng updateto Angular v20, the application migration will detect the usage of thekarmabuilder'skarmaConfigoption and attempt to remove usages of the no longer needed@angular-devkit/build-angularkarma framework and plugin usage. While the karma framework usage will be specifically ignored when using the@angular/build:karmabuilder, the plugin usage leverages a directrequirewithin the configuration file. Regardless of the ability of the builder to ignore, neither usage is needed with@angular/build:karmaand removing the code aligns with what would be generated byng generate config karma.Closes #30413