Skip to content

Conversation

lacolaco
Copy link
Contributor

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

unit-test builder doesn't inject zone.js/testing for Karma runner but only for Vitest.

Issue Number: #30595

What is the new behavior?

unit-test builder injects zone.js/testing for both of Karma and Vitest.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@lacolaco lacolaco force-pushed the fix-unit-test-polyfills branch from b16b911 to 6d9964f Compare June 25, 2025 03:46
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Jun 25, 2025
@alan-agius4 alan-agius4 linked an issue Jun 25, 2025 that may be closed by this pull request
1 task
…ution

`unit-test` builder doesn't inject `zone.js/testing` for `Karma` runner but only for `Vitest`.

Closes: angular#30595
@alan-agius4 alan-agius4 force-pushed the fix-unit-test-polyfills branch from 6d9964f to bdb11f6 Compare June 25, 2025 06:33
@alan-agius4 alan-agius4 removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jun 25, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 25, 2025
@jkrems jkrems merged commit e0de868 into angular:main Jun 25, 2025
32 checks passed
@lacolaco lacolaco deleted the fix-unit-test-polyfills branch June 25, 2025 14:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[unit-test] karma runner doesn't support zone.js/testing auto injection

3 participants