Skip to content

refactor: use executeWithCases instead of RXJS boillerplate #30672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

refactor: use executeWithCases instead of RXJS boillerplate #30672

merged 1 commit into from
Jul 10, 2025

Conversation

alan-agius4
Copy link
Collaborator

Clean up several tests

@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label Jul 8, 2025
@alan-agius4 alan-agius4 force-pushed the rxjs-tests-helpers branch 9 times, most recently from 95024d1 to 7299a2f Compare July 9, 2025 07:45
@alan-agius4 alan-agius4 requested a review from jkrems July 9, 2025 09:00
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 9, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review July 9, 2025 09:01
@alan-agius4 alan-agius4 force-pushed the rxjs-tests-helpers branch from 7299a2f to 23bb759 Compare July 9, 2025 09:33
@alan-agius4 alan-agius4 force-pushed the rxjs-tests-helpers branch from 23bb759 to 2a44505 Compare July 9, 2025 09:36
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Jul 10, 2025
@alan-agius4 alan-agius4 requested a review from clydin July 10, 2025 12:59
@alan-agius4 alan-agius4 removed the request for review from jkrems July 10, 2025 13:57
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 10, 2025
@alan-agius4 alan-agius4 merged commit 3c38877 into angular:main Jul 10, 2025
32 checks passed
@alan-agius4 alan-agius4 deleted the rxjs-tests-helpers branch July 10, 2025 13:58
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 20.1.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clydin clydin clydin approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-agius4 @clydin