-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@schematics/angular): add schematics to generate ai context files #30763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b3aef30 to
736c88d
Compare
70ae7ec to
288dcfd
Compare
288dcfd to
53d6719
Compare
53d6719 to
7fd0e75
Compare
7fd0e75 to
c94f532
Compare
3dc7023 to
5ae2b77
Compare
048a5d7 to
19858e9
Compare
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things and the commit message is still outdated.
23a1442 to
ec4df12
Compare
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly NITs, but I think there is a bug with the "none" value.
| "tool": { | ||
| "type": "array", | ||
| "uniqueItems": true, | ||
| "x-prompt": "Which AI tools do you want to configure with Angular best practices? https://angular.dev/ai/develop-with-ai", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: As a follow up can we improve the prompt to include some more details
"x-prompt": {
"message": "Which AI tools do you want to configure with Angular best practices? https://angular.dev/ai/develop-with-ai",
"type": "list",
"items": [
{
"value": "none",
"label": "None"
},
{
"value": "copilot",
"label": "Copilot powered IDEs [ https://https://code.visualstudio.com/docs/copilot/copilot-customization#_custom-instructions ]"
},
{
"value": "cursor",
"label": "Cursor [ https://docs.cursor.com/en/context/rules ]"
}
]
...
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take care of it in a follow up.
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a couple of mistakes in the commit message (fixed below)
* `ng generate ai-config` to prompt support tools.
* `ng generate ai-config --tool=gemini` to specify the tool.
* `ng new` will prompt to config AI tools.
* `ng new --ai-config=gemini` to create a new project with AI configuration.
Supported AI tools: gemini, claude, copilot, windsurf, jetbrains, cursor.
packages/schematics/angular/ai-config/files/__rulesName__.template
Outdated
Show resolved
Hide resolved
packages/schematics/angular/ai-config/files/__rulesName__.template
Outdated
Show resolved
Hide resolved
95ce010 to
f0f59fc
Compare
f0f59fc to
6dc79b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 comments to fix the prompt, as I highly doubt it works right now.
151c778 to
37bd025
Compare
37bd025 to
895a07f
Compare
0db379b to
f9270a7
Compare
* `ng generate ai-config` to prompt support tools. * `ng generate ai-config --tool=gemini` to specify the tool. * `ng new` will prompt to config AI tools. * `ng new --ai-config=gemini` to create a new project with AI configuration. Supported AI tools: gemini, claude, copilot, windsurf, jetbrains, cursor.
f9270a7 to
37794af
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ng generate ai-configto prompt support tools.ng generate ai-config --tool=geminito specify the tool.ng newwill prompt to config AI tools.ng new --ai-config=geminito create a new project with AI configuration.Supported AI tools: gemini, claude, copilot, windsurf, jetbrains, cursor.