Skip to content

Conversation

alan-agius4
Copy link
Collaborator

This fixes an issue with sourcemaps

Closes #30731

This fixes an issue with sourcemaps

Closes angular#30731
@alan-agius4 alan-agius4 requested a review from jkrems July 24, 2025 16:51
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jul 24, 2025
*/

import { lookup as lookupMimeType } from 'mrmime';
import { createHash } from 'node:crypto';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated to the version bump / upstream fix for the source map issue. At least #30770 appears to pass CI without further changes. Can you add some context to the PR description?

Copy link
Collaborator Author

@alan-agius4 alan-agius4 Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because it was needed to bump to vite 7.0.5.

See: #30758

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, so effectively this is a revert. Thanks!

@alan-agius4 alan-agius4 requested a review from jkrems July 24, 2025 17:18
@jkrems jkrems added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 24, 2025
@alan-agius4 alan-agius4 merged commit ea5cd0e into angular:20.1.x Jul 24, 2025
55 of 58 checks passed
@alan-agius4 alan-agius4 deleted the vite-update-sm branch July 24, 2025 17:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@angular/build 20.1.0 totally breaks console logs line numbers in browser devtools

2 participants