perf(@schematics/angular): optimize AST traversal utilities #31049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
area: performance
clydin
added
the
action: review
alan-agius4
approved these changes
Aug 28, 2025
alan-agius4
added
action: merge
jkrems
approved these changes
Aug 28, 2025
Improves the performance of AST utility functions by reducing redundant work and memory allocations. - The `findNodes` function is now memoized with a `WeakMap`-based cache. This prevents repeated traversals of the entire source file AST when searching for nodes of the same kind, which is a common pattern. - The `getSourceNodes` function has been refactored to use a single array instead of two, reducing memory overhead and avoiding costly `shift()` operations.
clydin
force-pushed
the
ng-schematics/ast-perf
branch
from
4d591ff to
3009ebd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the performance of AST utility functions by reducing redundant work and memory allocations.
findNodesfunction is now memoized with aWeakMap-based cache. This prevents repeated traversals of the entire source file AST when searching for nodes of the same kind, which is a common pattern.getSourceNodesfunction has been refactored to use a single array instead of two, reducing memory overhead and avoiding costlyshift()operations.