fix(@angular/build): resolve PostCSS plugins relative to config file #31119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
14 tasks
alan-agius4
added
target: patch
clydin
reviewed
Sep 4, 2025
packages/angular/build/src/tools/esbuild/stylesheets/stylesheet-plugin-factory.ts
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
tailwinds-css
branch
from
4b0118d to
b381df8
Compare
clydin
approved these changes
Sep 4, 2025
Previously, PostCSS plugins were resolved from the location of `@angular/build`. This caused issues when the PostCSS configuration file was located in a subdirectory and used plugins not hoisted to the root `node_modules`, as plugins would not be found. This change updates the PostCSS configuration loading to resolve plugins relative to the directory containing the PostCSS configuration file. This ensures that plugins are correctly located regardless of the configuration files location.
alan-agius4
force-pushed
the
tailwinds-css
branch
from
b381df8 to
aaa6665
Compare
alan-agius4
added
action: merge
th0r
reviewed
Sep 19, 2025
| for (const [pluginName, pluginOptions] of options.postcssConfiguration.plugins) { | ||
| const { default: plugin } = await import(pluginName); | ||
|
|
||
| const postCssPluginRequire = createRequire(dirname(configPath) + '/'); |
There was a problem hiding this comment.
@alan-agius4 this change brakes importing of plugins that are ES modules as in this case the plugin below won't be a function, but an {default: <function>, __esModule: true} object and it won't pass a check below.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, PostCSS plugins were resolved from the location of
@angular/build. This caused issues when the PostCSS configuration file was located in a subdirectory and used plugins not hoisted to the rootnode_modules, as plugins would not be found.This change updates the PostCSS configuration loading to resolve plugins relative to the directory containing the PostCSS configuration file. This ensures that plugins are correctly located regardless of the configuration files location.