Skip to content

refactor(@angular/cli): exclude Cnpm from LOCKFILE_NAMES type #31140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

refactor(@angular/cli): exclude Cnpm from LOCKFILE_NAMES type #31140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/angular/cli/src/utilities/package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ import { memoize } from './memoize';
/**
* A map of package managers to their corresponding lockfile names.
*/
const LOCKFILE_NAMES: Readonly<Record<PackageManager, string | readonly string[]>> = {
const LOCKFILE_NAMES: Readonly<
Record<Exclude<PackageManager, PackageManager.Cnpm>, string | readonly string[]>
> = {
[PackageManager.Yarn]: 'yarn.lock',
[PackageManager.Pnpm]: 'pnpm-lock.yaml',
[PackageManager.Bun]: ['bun.lockb', 'bun.lock'],
Expand Down Expand Up @@ -289,7 +291,10 @@ export class PackageManagerUtils {
* @param filesInRoot An array of file names in the root directory.
* @returns True if the lockfile exists, false otherwise.
*/
private hasLockfile(packageManager: PackageManager, filesInRoot: string[]): boolean {
private hasLockfile(
packageManager: Exclude<PackageManager, PackageManager.Cnpm>,
filesInRoot: string[],
): boolean {
const lockfiles = LOCKFILE_NAMES[packageManager];

return typeof lockfiles === 'string'
Expand Down