fix(@angular/build): add upfront dependency validation for unit-test runners #31214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runners Previously, missing peer dependencies for test runners (e.g., `jsdom`, `karma-coverage`, `playwright`) were only discovered late in the execution process, often leading to cryptic errors. When multiple packages were missing, this resulted in a frustrating cycle of running the command, installing a package, and repeating. This change introduces a comprehensive, upfront dependency validation system: - A `validateDependencies` hook is added to the `TestRunner` interface, allowing each runner to declare its own requirements. - A `DependencyChecker` class now collects all missing dependencies and reports them to the user in a single, clean error message without a stack trace. - Both the Karma and Vitest runners implement this hook to check for all required packages based on the user's configuration (including browser launchers, coverage packages, and the JSDOM environment).
clydin
force-pushed
the
unit-test/dependency-checks
branch
from
f9bdc8a to
b3cb767
Compare
jkrems
approved these changes
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, missing peer dependencies for test runners (e.g.,
jsdom,karma-coverage,playwright) were only discovered late in the execution process, often leading to cryptic errors. When multiple packages were missing, this resulted in a frustrating cycle of running the command, installing a package, and repeating.This change introduces a comprehensive, upfront dependency validation system:
validateDependencieshook is added to theTestRunnerinterface, allowing each runner to declare its own requirements.DependencyCheckerclass now collects all missing dependencies and reports them to the user in a single, clean error message without a stack trace.