Skip to content

fix(@schematics/angular): use fixture.whenStable() instead of fixture detectChanges() for zoneless apps #31247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2025
Merged

fix(@schematics/angular): use fixture.whenStable() instead of fixture detectChanges() for zoneless apps #31247

merged 2 commits into from
Sep 26, 2025

Conversation

mistrykaran91
Copy link
Contributor

@mistrykaran91 mistrykaran91 commented Sep 18, 2025 •
edited
Loading

Closes #31193

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Currently, when we generate the app using add or generate command, for zoneless apps it uses fixture.detectChanges() whereas the docs says to use fixture.whenStable()

Issue Number: #31193

What is the new behavior?

If we now create zoneless apps, when generate or add command, fixture.whenStable() will be used.

See #31193

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mistrykaran91 mistrykaran91 marked this pull request as ready for review September 18, 2025 13:12
@clydin clydin requested a review from atscott September 18, 2025 16:21
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Sep 19, 2025
@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change detected: feature PR contains a feature commit area: build & ci Related the build and CI infrastructure of the project area: @angular/build area: @angular/cli area: @angular/ssr labels Sep 23, 2025
@mistrykaran91 mistrykaran91 force-pushed the fix/schematics-use-fixture-when-stable-instead-of-fixture-detect-changes branch from 978ce42 to 6830620 Compare September 23, 2025 04:34
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release labels Sep 24, 2025
atscott
atscott requested changes Sep 24, 2025
View reviewed changes
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 25, 2025
@mistrykaran91 mistrykaran91 force-pushed the fix/schematics-use-fixture-when-stable-instead-of-fixture-detect-changes branch from 6830620 to 61a5988 Compare September 25, 2025 06:06
@mistrykaran91 mistrykaran91 force-pushed the fix/schematics-use-fixture-when-stable-instead-of-fixture-detect-changes branch from 61a5988 to 48d279a Compare September 25, 2025 13:39
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 25, 2025
@alan-agius4
test: update no-zoneless jest e2e to account for `fixture.whenStabl…
523466f 
…e` change

This commit replaces `fixture.whenStable` to `fixture.detectChanges` in the Jest spec file when using zone.js
@clydin clydin removed the detected: breaking change PR contains a commit with a breaking change label Sep 26, 2025
@dgp1130 dgp1130 merged commit 0b55ebb into angular:main Sep 26, 2025
31 checks passed
@alan-agius4
Copy link
Collaborator

@mistrykaran91, thanks for your contribution.

@mistrykaran91
Copy link
Contributor Author

@mistrykaran91, thanks for your contribution.

Welcome, always happy to contribute :)

@mistrykaran91 mistrykaran91 deleted the fix/schematics-use-fixture-when-stable-instead-of-fixture-detect-changes branch September 27, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build area: @angular/cli area: @angular/ssr area: build & ci Related the build and CI infrastructure of the project area: @schematics/angular detected: feature PR contains a feature commit target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use fixture.whenStable() instead of fixture.detectChanges() for zoneless applications

5 participants

@mistrykaran91 @alan-agius4 @atscott @dgp1130 @clydin