refactor(@angular/cli): improve error handling and structure of zoneless tool #31261
+62
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess tool This commit refactors the `onpush-zoneless-migration` tool to improve its internal structure, readability, and error handling. The file discovery and categorization logic has been extracted from the main tool function into a new, dedicated `discoverAndCategorizeFiles` helper function. This change improves separation of concerns and makes the main function's orchestration role clearer. Additionally, focused `try...catch` blocks have been added to gracefully handle cases where the user provides an invalid or inaccessible file path. This prevents the tool from crashing and provides a clear error message to the user, while allowing other internal errors to propagate correctly.
clydin
added
action: review
atscott
approved these changes
Sep 22, 2025
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the
onpush-zoneless-migrationtool to improve its internal structure, readability, and error handling.The file discovery and categorization logic has been extracted from the main tool function into a new, dedicated
discoverAndCategorizeFileshelper function. This change improves separation of concerns and makes the main function's orchestration role clearer.Additionally, focused
try...catchblocks have been added to gracefully handle cases where the user provides an invalid or inaccessible file path. This prevents the tool from crashing and provides a clear error message to the user, while allowing other internal errors to propagate correctly.