Skip to content

refactor(@angular/ssr): disable streaming when rendering SSG page #31265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

refactor(@angular/ssr): disable streaming when rendering SSG page #31265

merged 1 commit into from
Sep 22, 2025

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Sep 22, 2025 •
edited
Loading

Streaming is not needed as this happens without network.

@alan-agius4 alan-agius4 requested a review from jkrems September 22, 2025 11:35
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Sep 22, 2025
@alan-agius4 alan-agius4 force-pushed the feat/ssr-critical-css-refactor branch from 6eee167 to 969e180 Compare September 22, 2025 12:08
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Sep 22, 2025
@alan-agius4 alan-agius4 force-pushed the feat/ssr-critical-css-refactor branch 3 times, most recently from fc93fb0 to d6c00f7 Compare September 22, 2025 13:36
@alan-agius4
refactor(@angular/ssr): disable streaming when rendering SSG page
e147fde 
Streaming is not needed as this happens without network.
@alan-agius4 alan-agius4 force-pushed the feat/ssr-critical-css-refactor branch from d6c00f7 to e147fde Compare September 22, 2025 13:37
jkrems
jkrems approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@jkrems jkrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is just for clarity reasons / because streaming was effectively not used in the SSG case..? Might be good to call that out in the commit message and/or PR description for future context.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 22, 2025
@alan-agius4 alan-agius4 merged commit 2b0f6d6 into angular:main Sep 22, 2025
56 of 57 checks passed
@alan-agius4 alan-agius4 deleted the feat/ssr-critical-css-refactor branch September 22, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkrems jkrems jkrems approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/ssr target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alan-agius4 @jkrems