Skip to content

build: update rolldown to v1.0.0-beta.38 #31268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

build: update rolldown to v1.0.0-beta.38 #31268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/build/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"parse5-html-rewriting-stream": "8.0.0",
"picomatch": "4.0.3",
"piscina": "5.1.3",
"rolldown": "1.0.0-beta.32",
"rolldown": "1.0.0-beta.38",
"sass": "1.90.0",
"semver": "7.7.2",
"source-map-support": "0.5.21",
Expand Down
3 changes: 2 additions & 1 deletion packages/angular/build/src/builders/application/chunk-optimizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,8 @@ export async function optimizeChunks(
});

const result = await bundle.generate({
minify: { mangle: false, compress: false, removeWhitespace: true },
minify: { mangle: false, compress: false },
advancedChunks: { minSize: 8192 },
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this work for you? When I do NG_BUILD_OPTIMIZE_CHUNKS=true ng build with @angular/[email protected], which contains this PR, then I see:

[INVALID_OPTION] Warning: Advanced chunks options (minSize) specified without groups. These options have no effect without groups - you should either add groups to use advanced chunking or remove these options.

And the amount of chunks seem to be the same as without this setting.

sourcemap,
chunkFileNames: (chunkInfo) => `${chunkInfo.name.replace(/-[a-zA-Z0-9]{8}$/, '')}-[hash].js`,
});
Expand Down
160 changes: 83 additions & 77 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.