Skip to content

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Vitest Browser mode generates screenshots on failed tests by default.

What is the new behavior?

This add the necessary entry in .gitignore to ignore these files

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cexbrayat cexbrayat changed the title fix(@schematics/angular): add **/__screeshots__ to .gitignore fix(@schematics/angular): add **/__screenshots__ to .gitignore Sep 23, 2025
@cexbrayat cexbrayat force-pushed the fix/ignore-screenshots branch from 3d758df to 20e402c Compare September 23, 2025 18:55
@clydin clydin added the target: patch This PR is targeted for the next patch release label Sep 23, 2025
@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Sep 23, 2025
@cexbrayat cexbrayat force-pushed the fix/ignore-screenshots branch from 20e402c to 9425f19 Compare September 23, 2025 19:22
Vitest Browser mode generates screenshots on failed tests by default.
@cexbrayat cexbrayat force-pushed the fix/ignore-screenshots branch from 9425f19 to f942e40 Compare September 23, 2025 19:23
@cexbrayat cexbrayat changed the title fix(@schematics/angular): add **/__screenshots__ to .gitignore fix(@schematics/angular): add __screenshots__/ to .gitignore Sep 23, 2025
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Sep 23, 2025
@clydin clydin merged commit 3af4dcb into angular:main Sep 24, 2025
32 checks passed
@clydin
Copy link
Member

clydin commented Sep 24, 2025

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants