refactor(@angular/ssr): replace logic to determine the original URL #31503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
refactor-replace-logic-to-determine
branch
from
c88a115 to
a74d324
Compare
hybrist
approved these changes
Oct 16, 2025
alan-agius4
force-pushed
the
refactor-replace-logic-to-determine
branch
3 times, most recently
from
a34918f to
3ec8ec3
Compare
atscott
reviewed
Oct 16, 2025
alan-agius4
force-pushed
the
refactor-replace-logic-to-determine
branch
from
3ec8ec3 to
121dd1e
Compare
alan-agius4
force-pushed
the
refactor-replace-logic-to-determine
branch
from
121dd1e to
ece6f86
Compare
atscott
approved these changes
Oct 16, 2025
Contributor
atscott
left a comment
atscott
left a comment
There was a problem hiding this comment.
Hope this works! 🤞 The URL construction part always confuses me...
alan-agius4
force-pushed
the
refactor-replace-logic-to-determine
branch
2 times, most recently
from
e39c6a7 to
f04ff8d
Compare
Collaborator
Author
|
@atscott, the unit tests says it works :) thanks for this. |
alan-agius4
added
action: merge
Collaborator
Author
|
Looks like the last change causes some E2Es to fail. I’ll take a look tomorrow. |
alan-agius4
force-pushed
the
refactor-replace-logic-to-determine
branch
from
f04ff8d to
00060d3
Compare
Using `currentNavigation` might not work in all cases as this will be null when the navigate has already completed.
alan-agius4
force-pushed
the
refactor-replace-logic-to-determine
branch
from
00060d3 to
9d19533
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
currentNavigationmight not work in all cases as this will be null when the navigate has already completed.