Skip to content

fix(@angular/ssr): handle undefined ɵgetOrCreateAngularServerApp #31739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(@angular/ssr): handle undefined ɵgetOrCreateAngularServerApp #31739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/angular/ssr/src/app-engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,17 @@ export class AngularAppEngine {
return null;
}

const { ɵgetOrCreateAngularServerApp } = entryPoint;
if (!ɵgetOrCreateAngularServerApp) {
// Sometimes in Vite `ɵgetOrCreateAngularServerApp` is undefined,
// which causes a runtime error `Error: ɵgetOrCreateAngularServerApp is not a function`
// See: https://github.com/angular/angular-cli/issues/31671
return null;
}

// Note: Using `instanceof` is not feasible here because `AngularServerApp` will
// be located in separate bundles, making `instanceof` checks unreliable.
const ɵgetOrCreateAngularServerApp =
entryPoint.ɵgetOrCreateAngularServerApp as typeof getOrCreateAngularServerApp;

const serverApp = ɵgetOrCreateAngularServerApp({
const serverApp = (ɵgetOrCreateAngularServerApp as typeof getOrCreateAngularServerApp)({
allowStaticRouteRender: AngularAppEngine.ɵallowStaticRouteRender,
hooks: AngularAppEngine.ɵhooks,
});
Expand Down