Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

angular / angular-cli Public

Notifications You must be signed in to change notification settings
Fork 11.9k
Star 27k

Code
Issues 257
Pull requests 21
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

fix(@schematics/angular): do not set `esModuleInterop` and `moduleResolution` when module is `preserve` #31909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dgp1130 merged 1 commit into angular:main from Deku-nattsu:migration

Nov 21, 2025

Merged

fix(@schematics/angular): do not set `esModuleInterop` and `moduleResolution` when module is `preserve` #31909

dgp1130 merged 1 commit into angular:main from Deku-nattsu:migration

Nov 21, 2025

+21 −2

Conversation 12 Commits 1 Checks 34 Files changed 2

Conversation

Copy link

Contributor

Deku-nattsu commented Nov 21, 2025

PR Checklist

Please check to confirm your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Migrating from v20 to v21 causes both esModuleInterop and moduleResolution to be added again which isn't needed when module is set to preserve

Does this PR introduce a breaking change?

Yes
No

Other information

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

angular-robot bot added the area: @schematics/angular label

alan-agius4 approved these changes

View reviewed changes

Copy link

Collaborator

alan-agius4 left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one NIT.

Would also be nice to add a test for this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

packages/schematics/angular/migrations/use-application-builder/migration.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label

alan-agius4 reviewed

View reviewed changes

packages/schematics/angular/migrations/use-application-builder/migration.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 added the target: patch This PR is targeted for the next patch release label

Deku-nattsu force-pushed the migration branch from aad8a06 to e68a190 Compare

November 21, 2025 14:48

Copy link

Contributor Author

Deku-nattsu commented Nov 21, 2025

LGTM, just one NIT.

Would also be nice to add a test for this.

okay i'll try

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label

Deku-nattsu force-pushed the migration branch from e68a190 to 27f535e Compare

November 21, 2025 15:16

Copy link

Contributor Author

Deku-nattsu commented Nov 21, 2025

i used the same setup in https://github.com/angular/angular-cli/blob/main/packages/schematics/angular/migrations/update-module-resolution/migration_spec.ts#L109

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 reviewed

View reviewed changes

packages/schematics/angular/migrations/use-application-builder/migration_spec.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 reviewed

View reviewed changes

packages/schematics/angular/migrations/use-application-builder/migration_spec.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 reviewed

View reviewed changes

packages/schematics/angular/migrations/use-application-builder/migration_spec.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 reviewed

View reviewed changes

packages/schematics/angular/migrations/use-application-builder/migration_spec.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Collaborator

alan-agius4 commented Nov 21, 2025

i used the same setup in https://github.com/angular/angular-cli/blob/main/packages/schematics/angular/migrations/update-module-resolution/migration_spec.ts#L109

Interesting, probably that could be cleaned up a bit hahaha.

Deku-nattsu reacted with laugh emoji

All reactions

😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          fix(@schematics/angular): do not set esModuleInterop and `moduleRes…

0a9b7cb

…olution` when module is `preserve`

Deku-nattsu force-pushed the migration branch from 27f535e to 0a9b7cb Compare

November 21, 2025 15:31

alan-agius4 approved these changes

View reviewed changes

Copy link

Collaborator

alan-agius4 left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Deku-nattsu reacted with rocket emoji

All reactions

🚀 1 reaction

alan-agius4 added the action: merge The PR is ready for merge by the caretaker label

dgp1130 merged commit 50d9c0e into angular:main

35 checks passed

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Collaborator

dgp1130 commented Nov 21, 2025

This PR was merged into the repository. The changes were merged into the following branches:

main: 50d9c0e
21.0.x: 4534c98

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

The PR is ready for merge by the caretaker

area: @schematics/angular target: patch

This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.