fix(@schematics/angular): silently skip when the build target already uses one of the new builders #31911
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… uses one of the new builders
alan-agius4
reviewed
Nov 21, 2025
| continue; | ||
| } | ||
|
|
||
| if (buildTarget.builder.startsWith('@angular/build')) { |
Collaborator
There was a problem hiding this comment.
The check in https://github.com/Deku-nattsu/angular-cli/blob/9d7db9ea1b0837f282b4c0effe157170b0d6eca7/packages/schematics/angular/migrations/use-application-builder/migration.ts#L177C51-L177C71 should be updated to
if (!buildTarget || buildTarget.builder === Builders.Application
|| buildTarget.builder === Builders.BuildApplication) {
alan-agius4
added
target: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current when migrating an app that's already using the new builders, it shows an unnecessary warning that imo should be only displayed for non supported builders
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information