Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Jan 7, 2026

This change enables the unit-test builder to correctly extract base build options from @angular/build:ng-packagr targets. It parses the ng-package.json file to retrieve configuration for assets, inlineStyleLanguage, and stylePreprocessorOptions, ensuring that libraries can be unit-tested effectively.

Closes #30542

@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: @angular/build labels Jan 7, 2026
@clydin clydin force-pushed the unit-test/ng-packagr branch from 1fda0c2 to 8269cf5 Compare January 7, 2026 18:39
@clydin clydin changed the title feat(@angular/build): support ng-packagr in unit-test builder feat(@angular/build): directly support ng-packagr in unit-test builder Jan 7, 2026
@clydin clydin force-pushed the unit-test/ng-packagr branch from 8269cf5 to 23970d5 Compare January 7, 2026 19:49
This change enables the `unit-test` builder to correctly extract base build options from `@angular/build:ng-packagr` targets. It parses the `ng-package.json` file to retrieve configuration for `assets`, `inlineStyleLanguage`, and `stylePreprocessorOptions`, ensuring that libraries can be unit-tested effectively.
@clydin clydin force-pushed the unit-test/ng-packagr branch from 23970d5 to ef443bf Compare January 7, 2026 20:23
@clydin clydin marked this pull request as ready for review January 7, 2026 21:15
@clydin clydin added target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 7, 2026
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 8, 2026
@clydin clydin merged commit 1eda0a9 into angular:main Jan 8, 2026
38 checks passed
@clydin
Copy link
Member Author

clydin commented Jan 8, 2026

This PR was merged into the repository. The changes were merged into the following branches:

@clydin clydin deleted the unit-test/ng-packagr branch January 8, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing options for Vitest config (Library Builder)

2 participants