fix(sort): If there is no direction, setting active as empty #15169

[Suresh918]

Fixes #15169

[andrewseguin]

Thanks for sending this PR @Suresh918.

Looks good to me, just a small nit. Can you change the jsDoc for active so that it does not say it is just the most recently sorted sortable?

Also, I think we ought to initialize it as an empty string now, so there's no ambiguity between undefined and ''.

  /** The id of the sorted MatSortable. */
  @Input('matSortActive') active: string = '';

[Suresh918]

@andrewseguin Updated the JS doc. Can you please check.
Are there any ways to chat in private to discuss doubts ?

[andrewseguin]

Cool thanks

Feel free to chat over the PR, it's nice for us to keep things documented for future reference. Would be happy to hear your thoughts/doubts on this

[Suresh918]

@andrewseguin When this pull request will be merged?

[andrewseguin]

Unfortunately it takes a good amount of time to get changes in due to the myriad of tests that need to pass internally. I'll move this up to P2 to help prioritize it.

Do you mind rebasing so we'll be able to re-run tests when we're able

[Suresh918]

@andrewseguin I created a new pull request for this with the same changes
#22029
as it is difficult to rebase as there are changes in the folders from the instant this merge request was created.

[annieyw]

Closing as there is a newer version of this change. (#22029)

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}