Skip to content

Conversation

fetis
Copy link
Contributor

@fetis fetis commented Jan 28, 2021

Native adapter still uses hardcoded 0 value. I applied a fix mentioned here #8100

@fetis fetis requested a review from mmalerba as a code owner January 28, 2021 15:55
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 28, 2021
@fetis fetis force-pushed the first_day_week_fix branch from 4eba7ef to 52b8fa6 Compare January 28, 2021 16:12
@fetis fetis changed the title fix: First day of the week from locale data fix(native-adapter): first day of the week from locale data Jan 28, 2021
@fetis fetis force-pushed the first_day_week_fix branch from 52b8fa6 to 220bbc7 Compare January 28, 2021 17:49
@fetis fetis changed the title fix(native-adapter): first day of the week from locale data fix(material/core): native-adapter uses first day of the week from locale data Jan 28, 2021
@mmalerba
Copy link
Contributor

The change looks good once CI is passing

@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin andrewseguin added the target: patch This PR is targeted for the next patch release label Apr 22, 2022
@andrewseguin
Copy link
Contributor

I rebased but it looks like its failing some tests

@crisbeto
Copy link
Member

Done in #29802.

@crisbeto crisbeto closed this Sep 30, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants