feat(cdk/table): add optional footer to cdk-text-column #29399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jullierme
requested review from
andrewseguin and
crisbeto
and removed request for
a team
jullierme
force-pushed
the
add-footer-cell-to-text-column
branch
2 times, most recently
from
d14ff92 to
36fa0ab
Compare
Added two new inputs to CdkTextColumn: `footerText` (string) and `footerTextTransform` (function), automatically inherited by MatTextColumn. If the table does not define a footer, the column footer will be ignored. Additionally, TextColumnOptions includes a new default function called `defaultFooterTextTransform`, used when neither `footerTextTransform` nor `footerText` are provided. Fixes angular#24532
jullierme
force-pushed
the
add-footer-cell-to-text-column
branch
from
36fa0ab to
61169f4
Compare
|
@crisbeto this one is also green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two new inputs to
CdkTextColumn:footerText(string) andfooterTextTransform(function), automatically inherited by MatTextColumn.If the table does not define a footer, the column footer will be ignored.
Additionally,
TextColumnOptionsincludes a new default function calleddefaultFooterTextTransform, used when neitherfooterTextTransformnorfooterTextare provided.Fixes #24532