fix(material/form-field): Don't allow label to grow larger than input #29673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested review from
andrewseguin and
crisbeto
and removed request for
a team
crisbeto
approved these changes
Aug 31, 2024
| padding-left: 16px; | ||
| padding-right: 16px; | ||
|
|
||
| @include _supports-max { |
There was a problem hiding this comment.
Heads-up that we inherited this _supports-max logic from MDC and reducing the specificity might be break-ey during the presubmit.
mmalerba
force-pushed
the
ff-overflow
branch
from
49556a4 to
67b5f82
Compare
mmalerba
added
action: merge
mmalerba
added a commit
that referenced
this pull request
Sep 9, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26558
Note: the label may still briefly be larger than the form-field, during transition from resting to floating. Users may choose to add a CSS animation for this, but we don't want to bake it in because it may negatively impact performance.