Skip to content

fix(material/select): Update checkbox color to match the selected label text color #29684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(material/select): Update checkbox color to match the selected label text color #29684

merged 1 commit into from
Sep 10, 2024

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Sep 3, 2024 •
edited
Loading

Fixes #29553

Before
image
image

After
image
image

@amysorto amysorto requested a review from a team as a code owner September 3, 2024 15:52
@amysorto amysorto requested review from crisbeto and mmalerba and removed request for a team September 3, 2024 15:52
@amysorto amysorto removed the request for review from mmalerba September 10, 2024 20:08
@amysorto amysorto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 10, 2024
@amysorto amysorto merged commit 4d0a3ef into angular:main Sep 10, 2024
24 checks passed
amysorto added a commit that referenced this pull request Sep 10, 2024
@amysorto
fix(material/select): Update checkbox color to match the selected lab…
57028df 
…el text color (#29684)

(cherry picked from commit 4d0a3ef)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(material/select): Material 3 mat-selects use the secondary color for selected item backgrounds (when the component is styled to primary)

2 participants

@amysorto @crisbeto