Skip to content

docs(material/select): prevent select from jumping in custom trigger example #29746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

docs(material/select): prevent select from jumping in custom trigger example #29746

merged 1 commit into from
Sep 17, 2024

Conversation

crisbeto
Copy link
Member

The mat-select in the custom trigger example was jumping around, because the projected span didn't have a line-height.

Fixes #29743.

@crisbeto
docs(material/select): prevent select from jumping in custom trigger …
edf5f55 
…example

The `mat-select` in the custom trigger example was jumping around, because the projected `span` didn't have a `line-height`.

Fixes angular#29743.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 17, 2024
@crisbeto crisbeto requested a review from a team as a code owner September 17, 2024 08:43
@crisbeto crisbeto requested review from andrewseguin and wagnermaciel and removed request for a team September 17, 2024 08:43
@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 17, 2024
@crisbeto crisbeto mentioned this pull request Sep 17, 2024
Closed
1 task
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 17, 2024
@crisbeto crisbeto merged commit 2dd269e into angular:main Sep 17, 2024
25 of 27 checks passed
crisbeto added a commit that referenced this pull request Sep 17, 2024
@crisbeto
docs(material/select): prevent select from jumping in custom trigger …
0728d9f 
…example (#29746)

The `mat-select` in the custom trigger example was jumping around, because the projected `span` didn't have a `line-height`.

Fixes #29743.

(cherry picked from commit 2dd269e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@amysorto amysorto amysorto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(mat-select): Span inside of mat-select-trigger causes height to change by 1px

2 participants

@crisbeto @amysorto