Skip to content

Conversation

sidhanshamil
Copy link
Contributor

This PR adds support for the following mouse events to the map-advanced-marker component:

  • Double click (dblclick)
  • Mouse out (mouseout)
  • Mouse over (mouseover)
  • Mouse up (mouseup)
  • Right click (right-click)

These events were available in the deprecated map-marker and are now implemented to enable similar functionality in map-advanced-marker.

Testing:

  • Unit tests added for each event.

@sidhanshamil sidhanshamil requested a review from a team as a code owner September 17, 2024 10:50
@sidhanshamil sidhanshamil requested review from amysorto and crisbeto and removed request for a team September 17, 2024 10:50
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Sep 17, 2024
@sidhanshamil sidhanshamil changed the title feat(google-maps/map-advanced-marker): Add support for some mouse events feat(google-maps/map-advanced-marker): Add support for some mouse events #29741 Sep 18, 2024
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto removed the request for review from amysorto September 18, 2024 06:48
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Sep 18, 2024
@crisbeto
Copy link
Member

Can you run yarn bazel run //tools/public_api_guard:google-maps/google-maps.md_api.accept and push the changed file?

@crisbeto crisbeto merged commit 1bd976c into angular:main Sep 18, 2024
20 of 22 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants