Stepper forms integrations fixes #29826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto and
andrewseguin
and removed request for
a team
crisbeto
added
the
merge: preserve commits
Previously we were mocking out the `AbstractControl` type, because we didn't want to bring in additional code for the optional forms integration. That's no longer necessary, because we can use type-only imports.
`CdkStepper` has a `reset` method that reset all the controls to their initial values, but that won't necessarily put the form into its initial state, because form controls also show errors on submit by default and `AbstractControl.reset` won't reset the submitted state. These changes add a call to reset all child forms to their unsubmitted state. Fixes angular#29781.
crisbeto
force-pushed
the
29781/stepper-reset
branch
from
6559f66 to
11b7fea
Compare
andrewseguin
approved these changes
Oct 4, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues with the integration between the CDK stepper and the forms module.
fix(cdk/stepper): remove mock of forms type
Previously we were mocking out the
AbstractControltype, because we didn't want to bring in additional code for the optional forms integration. That's no longer necessary, because we can use type-only imports.fix(cdk/stepper): reset submitted state when resetting stepper
CdkStepperhas aresetmethod that reset all the controls to their initial values, but that won't necessarily put the form into its initial state, because form controls also show errors on submit by default andAbstractControl.resetwon't reset the submitted state.These changes add a call to reset all child forms to their unsubmitted state.
Fixes #29781.