Skip to content

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Oct 4, 2024

Before:
image

After:
image

@amysorto amysorto added target: patch This PR is targeted for the next patch release area: material/chips labels Oct 4, 2024
@amysorto amysorto requested a review from a team as a code owner October 4, 2024 18:01
@amysorto amysorto requested review from crisbeto and wagnermaciel and removed request for a team October 4, 2024 18:01
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel strongly about this, but I think the idea with the basic chips is that they aren't supposed to have any styling. E.g. I don't see a padding in M2 either.

@amysorto
Copy link
Contributor Author

amysorto commented Oct 7, 2024

I don't feel strongly about this, but I think the idea with the basic chips is that they aren't supposed to have any styling. E.g. I don't see a padding in M2 either.

They have padding in GM2, so I'll close this PR and just update this for GM3.

@amysorto amysorto closed this Oct 7, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: material/chips target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants