Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 7, 2024

Reworks how we extract the tokens so we can output override calls instead of the full CSS variables.

Reworks how we extract the tokens so we can output `override` calls instead of the full CSS variables.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 7, 2024
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 7, 2024
@crisbeto crisbeto requested a review from andrewseguin October 7, 2024 19:25
@crisbeto crisbeto marked this pull request as ready for review October 7, 2024 19:25
@crisbeto crisbeto requested a review from a team as a code owner October 7, 2024 19:25
@crisbeto crisbeto requested a review from devversion October 7, 2024 20:28
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clever and clean! but also feels like Sass interplay could be better :D

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 8, 2024
@crisbeto crisbeto removed the request for review from andrewseguin October 8, 2024 06:57
@crisbeto crisbeto merged commit be543d1 into angular:main Oct 8, 2024
26 of 28 checks passed
crisbeto added a commit that referenced this pull request Oct 8, 2024
Reworks how we extract the tokens so we can output `override` calls instead of the full CSS variables.

(cherry picked from commit be543d1)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants