fix(material/datepicker): adds aria-describedby value for comparison date range #29910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
andrewseguin and
mmalerba
and removed request for
a team
essjay05
force-pushed
the
datepicker-comparison-add-sr-announcements
branch
from
2a5bb04 to
66466d0
Compare
jelbourn
added
the
dev-app preview
|
Deployed dev-app for 44499b2 to: https://ng-dev-previews-comp--pr-angular-components-29910-dev-t33hrm6g.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
essjay05
force-pushed
the
datepicker-comparison-add-sr-announcements
branch
from
66466d0 to
9d4b381
Compare
essjay05
force-pushed
the
datepicker-comparison-add-sr-announcements
branch
from
44499b2 to
5eb3ff3
Compare
|
Converting to draft while I integrate the latest DatePicker changes. |
Updates previous change to new datepicker changes.
Updates previous fix by creating a comparisonDateLabel value in MatDatePickerIntl to allow for further accessibility in allowing the text to be converted and translated. Fixes b/195600299
Updates previous fix to remove - for Ids in calendar-body.ts and revises comparisonDateLabel value to be Comparison range as recommended. Fixes b/195600299
This reverts commit 5eb3ff3.
essjay05
force-pushed
the
datepicker-comparison-add-sr-announcements
branch
from
5eb3ff3 to
38033c0
Compare
|
Fixed with this PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Angular Components Datepicker component calendar-body to check for a comparison start and comparison end date value and implement aria-describedby id values to correspond with hidden spans that describe a sub range start and a sub range end date if it does exist so that it is read by the screenreader and improves accessibility.
Before screencast
After screencast
Fixes b/195600299