Skip to content

Conversation

dolav
Copy link
Contributor

@dolav dolav commented Oct 27, 2024

Adding missing attributes in MatProgressSpinnerHarness

…rness

Adding missing attributes in MatProgressSpinnerHarness
@dolav dolav requested a review from a team as a code owner October 27, 2024 04:54
@dolav dolav requested review from andrewseguin and mmalerba and removed request for a team October 27, 2024 04:54
@andrewseguin
Copy link
Contributor

Can you give some rationale for why a test should be checking the inputs to the component? Hardcoding those as attributes just to access them in a test seems like a considerable overhead and questionable from a testing perspective. I imagine there is some proxy measure you can use to determine this, e.g. basing your test on the inputs you provide, or by including your own custom attributes if the inputs are unknown

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants