Skip to content

Timepicker documentation #29941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2024
Merged

Timepicker documentation #29941

merged 2 commits into from
Nov 4, 2024

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 30, 2024

Adds docs and live examples for the timepicker. Also fixes a minor bug.

@crisbeto crisbeto added docs This issue is related to documentation merge: preserve commits When the PR is merged, a rebase and merge should be performed target: rc This PR is targeted for the next release-candidate labels Oct 30, 2024
@crisbeto crisbeto requested a review from a team as a code owner October 30, 2024 12:15
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team October 30, 2024 12:15
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 30, 2024
@crisbeto crisbeto requested a review from andrewseguin October 30, 2024 12:15
amysorto
amysorto reviewed Oct 30, 2024
View reviewed changes
src/material/timepicker/timepicker.md

If the user types in an invalid time string (for example `abc` or `24:67`), the timepicker input
will report the `matTimepickerParse` error. The string is parsed using the `parseTime` method of
the [the current date implementation](#choosing-a-date-implementation-and-format-settings).
Copy link
Contributor

@amysorto amysorto Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the choosing a date implementation and format section should appear before this section does?

Copy link
Member Author

@crisbeto crisbeto Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking with not putting it further up was that for most users they won't really need to choose an implementation since it'll reuse the one they already have for the datepicker.

@crisbeto
fix(material/timepicker): value considered as invalid by default
f2e2f70 
Fixes that the `_lastValueValid` was defaulting to false which meant that it would be considered as invalid on load.
@crisbeto
docs(material/timepicker): add timepicker documentation and live exam…
8e7a913 
…ples

Populates the timepicker's guide and add live examples.
crisbeto
crisbeto commented Oct 31, 2024
View reviewed changes
Copy link
Member Author

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feedback has been addressed.

src/material/timepicker/timepicker.md

If the user types in an invalid time string (for example `abc` or `24:67`), the timepicker input
will report the `matTimepickerParse` error. The string is parsed using the `parseTime` method of
the [the current date implementation](#choosing-a-date-implementation-and-format-settings).
Copy link
Member Author

@crisbeto crisbeto Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking with not putting it further up was that for most users they won't really need to choose an implementation since it'll reuse the one they already have for the datepicker.

@crisbeto crisbeto requested review from jelbourn and removed request for andrewseguin, jelbourn, mmalerba and wagnermaciel October 31, 2024 23:31
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 4, 2024
@crisbeto crisbeto merged commit ade32c6 into angular:main Nov 4, 2024
21 of 24 checks passed
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 5, 2024

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@amysorto amysorto amysorto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation docs This issue is related to documentation merge: preserve commits When the PR is merged, a rebase and merge should be performed target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @amysorto