Distinguish unique IDs per app #29948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
merge: preserve commits
crisbeto
force-pushed
the
id-gen
branch
6 times, most recently
from
d17ddf5 to
9dda5b0
Compare
Adds a service to generate unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
Switches to using the ID generator service to create unique IDs.
crisbeto
requested review from
andrewseguin and
mmalerba
and removed request for
a team
amysorto
approved these changes
Nov 1, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we generate unique IDs by declaring a file-level variable and incrementing it. The problem is that if there are multiple versions of Angular on the page at the same time, the IDs may collide. These changes switch to generating the variables through a common service that add the
APP_IDto the ID.