Youtube player startSeconds and ready event not working #29986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the `startSeconds` input wasn't doing anything if there's a placeholder. This used to work, but seems to have broken during the transition to using the placeholder. Fixes angular#29874.
Fixes that the `youtube-player`'s `ready` event wasn't emitting. The issue is that we create the outputs lazily based on a stream of newly-created players, however that stream emits after the `ready` event. Relates to angular#29874.
crisbeto
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
crisbeto
added
the
merge: preserve commits
wagnermaciel
approved these changes
Nov 11, 2024
crisbeto
added
target: rc
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following fixes for the
youtube-player:fix(youtube-player): startSeconds not applied when using placeholder
Fixes that the
startSecondsinput wasn't doing anything if there's a placeholder. This used to work, but seems to have broken during the transition to using the placeholder.fix(youtube-player): ready event not emitting
Fixes that the
youtube-player'sreadyevent wasn't emitting. The issue is that we create the outputs lazily based on a stream of newly-created players, however that stream emits after thereadyevent.Fixes #29874.