fix(cdk/tree): warn if mixed node types are used within the same tree #29995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the tree somewhat works if a flat node and a nested node are used together, however they can break down depending on the data that is passed in. These changes add a warning that will tell users to use a consistent node type. Fixes angular#29927.
crisbeto
added
merge: preserve commits
crisbeto
requested review from
amysorto and
wagnermaciel
and removed request for
a team
1 task
andrewseguin
approved these changes
Nov 11, 2024
...rial/tree/tree-nested-child-accessor-overview/tree-nested-child-accessor-overview-example.ts
Outdated
Show resolved
Hide resolved
...rial/tree/tree-nested-child-accessor-overview/tree-nested-child-accessor-overview-example.ts
Outdated
Show resolved
Hide resolved
wagnermaciel
approved these changes
Nov 11, 2024
Fixes docs that were combining flat and nested tree nodes.
crisbeto
force-pushed
the
29927/tree-warning
branch
from
2034650 to
188fc72
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tree somewhat works if a flat node and a nested node are used together, however they can break down depending on the data that is passed in.
These changes add a warning that will tell users to use a consistent node type.
Fixes #29927.