fix(material/menu): handle keyboard events through dispatcher #29997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin and
mmalerba
and removed request for
a team
andrewseguin
approved these changes
Nov 12, 2024
Currently `mat-menu` handles it keyboard events in the template, however this ignores the overlay's stacking context which can capture some events that it shouldn't. These changes switch the menu to handling the events through the common dispatcher instead. Fixes angular#29996.
crisbeto
force-pushed
the
29996/menu-keyboard-handler
branch
from
301cde2 to
d3b8b8f
Compare
crisbeto
added a commit
that referenced
this pull request
Nov 14, 2024
Currently `mat-menu` handles it keyboard events in the template, however this ignores the overlay's stacking context which can capture some events that it shouldn't. These changes switch the menu to handling the events through the common dispatcher instead. Fixes #29996. (cherry picked from commit 42f6a4a)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
mat-menuhandles it keyboard events in the template, however this ignores the overlay's stacking context which can capture some events that it shouldn't.These changes switch the menu to handling the events through the common dispatcher instead.
Fixes #29996.