fix(material/slider): add tick mark to end of slider #30009
Conversation
DBowen33
requested review from
crisbeto and
mmalerba
and removed request for
a team
src/material/slider/slider.html
Outdated
| <div #trackActive class="mdc-slider__track--active_fill"></div> | ||
| </div> | ||
| <div class="mdc-slider__end-tick-mark-container"> | ||
| @if (_cachedWidth) { |
There was a problem hiding this comment.
Why can't we reuse the rendering of the tick marks below?
There was a problem hiding this comment.
The rendering of the tickMarkContainer div and tick marks below is based on the showTickMarks flag. Since I want this end tick mark to be on the slider permanently regardless of the value of the showTickMarks flag, I thought to make a permanent div to hold the end tick mark.
Let me know if you recommend approaching it a different way!
There was a problem hiding this comment.
If it's always supposed to be there, couldn't we hardcode one div and position it with CSS?
DBowen33
force-pushed
the
slider-fix-pt2
branch
from
75fc818 to
7856471
Compare
DBowen33
force-pushed
the
slider-fix-pt2
branch
from
7856471 to
d0cf8bf
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
2 participants
add tick mark to end of slider for visual users to see end of slider. passes 3:1 color contrast ratio with background
fixes b/286300099