Skip to content

fix(cdk/table): run differ for all columns #30012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(cdk/table): run differ for all columns #30012

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
561f6e2
fix(cdk/table): run differ for all columns
Nov 13, 2024
bd700d2
fix(cdk/table): include comment
andrewseguin Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/cdk/table/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,10 @@ export class CdkTable<T>
* re-render that section.
*/
private _renderUpdatedColumns(): boolean {
const columnsDiffReducer = (acc: boolean, def: BaseRowDef) => acc || !!def.getColumnsDiff();
const columnsDiffReducer = (acc: boolean, def: BaseRowDef) => {
const diff = !!def.getColumnsDiff();
return acc || diff;
};

// Force re-render data rows if the list of column definitions have changed.
const dataColumnsChanged = this._rowDefs.reduce(columnsDiffReducer, false);
Expand Down
Loading