fix(multiple): use cross-compatible type for setTimeout #30073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that some places were raising an error due to the return type of `setTimeout` being different between the browser and Node.
crisbeto
requested review from
andrewseguin,
devversion and
mmalerba
and removed request for
a team
devversion
approved these changes
Nov 25, 2024
|
It's probably a bug if |
crisbeto
added a commit
that referenced
this pull request
Nov 25, 2024
Fixes that some places were raising an error due to the return type of `setTimeout` being different between the browser and Node. (cherry picked from commit 26a817c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that some places were raising an error due to the return type of
setTimeoutbeing different between the browser and Node.