mat.core migration fixes #30116
Merged
mat.core migration fixes #30116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the `mat.core` migration was breaking the whole update process if a stylesheet has syntax errors. Fixes angular#30115.
…e Material Adds a check in the `mat.core` migration so that it avoids parsing stylesheets that don't contain `@angular/material` altogether. This both makes the schematic faster and avoids potential issues for stylesheets we don't care about.
crisbeto
added
target: patch
crisbeto
requested review from
andrewseguin and
mmalerba
and removed request for
a team
andrewseguin
approved these changes
Dec 2, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following fixes for the
mat.coremigration:fix(material/schematics): error if stylesheet contains syntax errors
Fixes that the
mat.coremigration was breaking the whole update process if a stylesheet has syntax errors.fix(material/schematics): avoid parsing stylesheets that don't include Material
Adds a check in the
mat.coremigration so that it avoids parsing stylesheets that don't contain@angular/materialaltogether. This both makes the schematic faster and avoids potential issues for stylesheets we don't care about.Fixes #30115.